Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Reported by @atinux when
icon.ico
cannot be served on cloudflare deployments.Investigating this,
mapRequestToAsset
utility from@cloudflare/kv-asset-handler
, appends/index.html
always when a mime is not detected based on request extension! We usemime/lite
andico
is not there this will cause cloudflare to fail!Best approach is accessing assets meta but as a workaround, this PR uses full mime db (25KB instead of 8KB) for cloudflare.
π Checklist