Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routes exporting both API endpoints and a component are not code split for client/server. #322

Closed
ghalle opened this issue Oct 16, 2022 · 2 comments
Closed

Routes exporting both API endpoints and a component are not code split for client/server. #322

ghalle opened this issue Oct 16, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@ghalle
Copy link
Collaborator

ghalle commented Oct 16, 2022 •
edited
Loading

This can cause issues when using dependencies that are not meant to be used on the client.

I suspect it might also leak the source for the API endpoints, but I have yet to confirm it.

We probably need to apply a babel transform to separate the API endpoints from the component.
@ghalle ghalle added the bug Something isn't working label Oct 16, 2022
@nksaraf
Copy link
Member

nksaraf commented Oct 16, 2022 •
edited
Loading

yeah we should just remove it from the client bundle

@ryansolid
Copy link
Member

In setting up for SolidStarts next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed in mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See #1139 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ghalle @ryansolid @nksaraf