SolidStart Beta 2 #1139
Merged
SolidStart Beta 2 #1139
+8,499
−27,342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add all make islands: false the default but both modes work make it work with hackernews example too
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the work on our next stage of beta for SolidStart. This will be a large change.
The whole current adapter ecosystem goes away as well as including libraries like
@solidjs/routerand@solidjs/metaas built-ins. Additionally as you may have noticed those libraries have changed their APIs over the past couple months so suffice to say patterns around data loading have also changed.The content of this PR is largely covered by the RFC I posted a few months back: #1052
I think the biggest thing to be aware of with such a change is pretty much all of the existing issues/PRs no longer apply or should be taken somewhere else. From a code standpoint we shrunk the project to ~1400 lines of code compared to its previous ~10,800. So as you can imagine it just isn't the same project anymore internally.
I will be closing out all the issues and PRs after this release. It is also unlikely given our resources to continue fixing bugs on older versions. I realize this may be a severe inconvenience to many of you, and I apologize ahead. This is beta software and we just don't have the resources to maintain earlier beta versions. Ultimately the lack of resources was what influenced this refactor in the first place as we couldn't keep on top of the current issues as they were. So going back makes even less sense.
Thank you all for your understanding and patience as we boldly move forward with the future of Solid.