Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump.cjs updates example deps #721

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Conversation

AlexErrant
Copy link
Contributor

Helps prevent issues like #690

Could also do others like @solidjs/meta or @solidjs/router - just say the word!

@ryansolid
Copy link
Member

To be fair I released that version after you reported the bug. But to be fair having the examples on the latest for new installs probably isn't the worst thing. Like it will do that automatically anyway within the range but like you only install a template once so why not.

@ryansolid ryansolid merged commit 94512e0 into solidjs:main Feb 6, 2023
@AlexErrant
Copy link
Contributor Author

Yeah I only realized that after making the PR xD

@AlexErrant AlexErrant deleted the bump_examples branch March 6, 2023 21:46
birkskyum pushed a commit to birkskyum/solid-start that referenced this pull request Mar 9, 2023
* bump examples' solid-start version

* guard against no solid-start

* update solidJsVersion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants