fix #1814 incorrect typing embedding for h and html #1815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #1814
The
h/types/index.d.ts
insolid-js@1.7.8
is incorrect. It importshyper-dom-expressions
, buthyper-dom-expressions
is not included in thepackage.json
ofsolid-js
.By explictly importing the type
HyperScript
,tsc
can output the followingh/types/index.d.ts
, which is what we actually want.solid-js/html
has the same issue too.How did you test this change?
Run
pnpm run types
and check.d.ts
files underdist/
.