Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark SuspenseListContext as PURE to allow treeshaking #2201

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

titoBouzout
Copy link
Contributor

@titoBouzout titoBouzout commented Jun 30, 2024

Doing export { className } from "solid-js@1.8/web"; exports the whole unused reactive utils, seems to me the createContext call for SuspenseListContext is causing the issue.

references:
https://x.com/jlarky/status/1806908281618890951
https://bundlejs.com/?q=solid-js%401.8%2Fweb&treeshake=%5B%7B+className+%7D%5D&config=%7B%22esbuild%22%3A%7B%22minify%22%3Afalse%7D%7D
https://esbuild.github.io/api/#tree-shaking

How did you test this change?

I haven't test this change

Copy link

changeset-bot bot commented Jun 30, 2024

⚠️ No Changeset found

Latest commit: 6d14e78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

coveralls commented Jun 30, 2024

Pull Request Test Coverage Report for Build 9732385258

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.56%

Totals Coverage Status
Change from base Build 9716994460: 0.0%
Covered Lines: 4186
Relevant Lines: 4408

💛 - Coveralls

@ryansolid ryansolid merged commit 1afe035 into solidjs:main Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants