Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2282: Add Check for Proxy support #2284

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

chiefcll
Copy link
Contributor

Summary

On older browsers (Chrome < 49) Proxy is not supported. When using core-js to polyfill features - $PROXY in s always returns true, leading to proxy being true and Solid trying to use Proxy even though the browser doesn't support it.

How did you test this change?

I've tested these changes using lambdatest.com.
Chrome38
https://github.com/lightning-tv/solid-demo-app

Copy link

changeset-bot bot commented Sep 14, 2024

🦋 Changeset detected

Latest commit: c5b6ce2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Sep 14, 2024

Pull Request Test Coverage Report for Build 10999900293

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.009%) to 93.351%

Files with Coverage Reduction New Missed Lines %
packages/solid/store/src/mutable.ts 1 93.87%
packages/solid/src/reactive/signal.ts 15 93.14%
Totals Coverage Status
Change from base Build 10692001464: 0.009%
Covered Lines: 4200
Relevant Lines: 4433

💛 - Coveralls

@ryansolid ryansolid merged commit 9e192d7 into solidjs:main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants