fix #2282: Add Check for Proxy support #2284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On older browsers (Chrome < 49) Proxy is not supported. When using core-js to polyfill features -
$PROXY in s
always returns true, leading to proxy being true and Solid trying to use Proxy even though the browser doesn't support it.How did you test this change?
I've tested these changes using lambdatest.com.
https://github.com/lightning-tv/solid-demo-app