Fix feature_helper require #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solidusio/solidus_support#28 Some files, this this feature_helper, were moved from solidus_support to solidus_dev_support. This updates the testing requrie to get the file from the correct place.
The solidus_dev_support requirement from the previous commit includes an implicit dependency on a higher version of capybara than we currently support. The update is trivial and only requires one small whitespace related change for a have_content assertion.
aldesantis
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
feature_helperfile included inspec_helperhas been moved to a different gem.Including
solidus_dev_supportgives access to thisfeature_helper.An update to
capybarawas also required tobundle install, but with a simple bump and one small test change works correctly.This should correct the red tests on circleci.