Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a basic spec_helper for extensions to include #2

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Add a basic spec_helper for extensions to include #2

merged 1 commit into from
Jul 26, 2017

Conversation

jhawthorn
Copy link
Contributor

tvdeyen
tvdeyen approved these changes Jul 26, 2017
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

mamhoff
mamhoff reviewed Jul 26, 2017
View reviewed changes
lib/solidus_support/extension/spec_helper.rb Outdated
require 'capybara-screenshot/rspec'
require 'capybara/poltergeist'

Capybara.register_driver :poltergiest do |app|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poltergeist

@jhawthorn
Copy link
Contributor Author

Going to split this into rails_helper.rb, feature_helper.rb, and spec_helper.rb

@jhawthorn jhawthorn merged commit 6c5b411 into solidusio:master Jul 26, 2017
@jhawthorn jhawthorn deleted the spec_helper branch July 26, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff left review comments

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhawthorn @tvdeyen @mamhoff