Fixes isse when zeitwerk is not enabled #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softr8
force-pushed
the
fix/autoloaders
branch
from
269c8f8 to
78de5b3
Compare
If autoloaders is defined in the Rails object, but the autoloader zeitwerk is not used, it is defined but returns nil when calling `main`, this ensures the extra check.
softr8
force-pushed
the
fix/autoloaders
branch
from
78de5b3 to
8f05db6
Compare
|
@softr8 thanks, good catch! |
aldesantis
approved these changes
Jan 3, 2020
|
@kennyadsl could you take a look when you have the chance, since you worked on the original change? |
|
Updated recently and am also running into this issue. Thanks @softr8 for reporting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If autoloaders is defined in the Rails object, but the autoloader zeitwerk is not used, it is defined but returns nil when calling
main.It is not enough to check here if autoloaders are enabled, it actually returns true, because it is registered, but if zeitwerk is disabled,
Rails.autoloaders.mainreturns nil causing a no method error