Load Solidus engine extension files automatically #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
reviewed
Jan 31, 2020
aldesantis
force-pushed
the
feature/enable-engines-conditionally
branch
from
af42b93 to
061a674
Compare
|
@aldesantis I have one concern. We're adding new private methods to a class that inherits form So, instead of for example |
aldesantis
changed the title
|
@spaghetticode I think that's a good point. It seems unlikely that Rails will officially introduce the concept of engines at some point, but it doesn't hurt to give the methods names that are a bit more specific. |
aldesantis
force-pushed
the
feature/enable-engines-conditionally
branch
2 times, most recently
from
f5f0aab to
3ebfcbc
Compare
aldesantis
changed the title
aldesantis
force-pushed
the
feature/enable-engines-conditionally
branch
4 times, most recently
from
86e0126 to
3bdaf27
Compare
aldesantis
force-pushed
the
feature/enable-engines-conditionally
branch
4 times, most recently
from
135f486 to
ce65e35
Compare
By cleanly separating extension files for the different Solidus engines, we can only load solidus_backend files when the engine itself is available rather than doing it all the time. In turn, this allows extensions to only actually require the parts of Solidus that they really need.
aldesantis
force-pushed
the
feature/enable-engines-conditionally
branch
from
ce65e35 to
0073fc6
Compare
spaghetticode
approved these changes
Jan 31, 2020
This module doesn't just deal with decorators anymore, but also loads views and controllers, so this seems like a better name. Separating it into two modules wouldn't be simple because they are interlinked.
aldesantis
force-pushed
the
feature/enable-engines-conditionally
branch
from
a2379e3 to
947778a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves
EngineExtensions::Decoratorsto automatically load the right files when Solidus engines are installed. For instance, if solidus_backend is installed, it will tell Rails to loadlib/views/backendandlib/controllers/backend, as well as the decorators inlib/decorators/backend.This also renames
SolidusSupport::EngineExtensions::DecoratorstoSolidusSupport::EngineExtensions, since the module doesn't only deal with decorators anymore.