Add payment method parent class #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to get the parent class for payment methods.
For Solidus < 2.3 it is Spree::PaymentMethod for non credit card
payment methods or Spree::Gateway for credit card payment methods.
For Solidus >= 2.3 it is Spree::PaymentMethod for non credit card
payment methods or Spree::PaymentMethod::CreditCard for credit card
payment methods.
Usage:
My::NonCreditCardPaymentMethod < SolidusSupport.payment_method_parent_class
My::CreditCardPaymentMethod <
SolidusSupport.payment_method_parent_class(credit_card: true)
jordan-brough
approved these changes
Jan 9, 2018
jhawthorn
reviewed
Jan 24, 2018
| @@ -24,6 +24,18 @@ def payment_source_parent_class | |||
| end | |||
| end | |||
|
|
|||
| def payment_method_parent_class(credit_card: false) | |||
There was a problem hiding this comment.
Since this is only useful when credit_card is true (otherwise it is Spree::PaymentMethod in all versions).
Maybe we should call this credit_card_payment_method_parent_class instead, and only deal with that case?
Either way 👍
|
@jhawthorn would you mind to review your comment? |
|
Looks fine to me |
|
I'm agree with @jhawthorn. Since there isn't a change for non-credit card payment methods, I think is not useful include them. 👍 to add a test suite Aside, there are differences about how define partial name and provider class in gateway between some versions that could be useful in this lib. I build something similar in a payment extension. Not sure what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SolidusSupport.payment_method_parent_classThis helps to get the parent class for payment methods.
For Solidus < 2.3 it is
Spree::PaymentMethodfor non credit card payment methods orSpree::Gatewayfor credit card payment methods.For Solidus >= 2.3 it is
Spree::PaymentMethodfor non credit card payment methods orSpree::PaymentMethod::CreditCardfor credit card payment methods.Usage: