Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gh binaries #197

Merged
merged 1 commit into from
Oct 12, 2020
Merged

fix gh binaries #197

merged 1 commit into from
Oct 12, 2020

Conversation

yuval-k
Copy link
Member

@yuval-k yuval-k commented Oct 12, 2020

Description

Please include a summary of the changes.

This bug fixes ... \ This new feature can be used to ...

Context

Users ran into this bug doing ... \ Users needed this feature to ...

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make install-deps generated-code from tools/wasme/cli to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@soloio-bulldozer soloio-bulldozer bot merged commit 6ccdcc2 into master Oct 12, 2020
@soloio-bulldozer soloio-bulldozer bot deleted the fix-gh-bin branch October 12, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants