PC: make build using gcc 10 work. #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, the root cause can be found in the gcc 10 release notes:
Therefore, specifying |
gcc 10 changed its default behavior from `-fcommon' to `-fno-common' for C code. (see https://gcc.gnu.org/gcc-10/changes.html). This makes linking the PC version of the solo firmware fail due to duplicate symbols. This change adds '-fcommon' to CFLAGS to restore the old behavior. It works using older compiler versions, too. Tested to build successfully on Ubuntu 20.10 using gcc-8, gcc-9, gcc-10 (default), clang-9, clang-10 and clang-11 (default).
enrikb
force-pushed
the
bugfix/make_PC_build_gcc_10_work
branch
from
5ede368 to
fbd1824
Compare
|
I changed the PR to set `-fcommon' in the Makefile, as it addresses the root cause more directly. No code changes. |
|
|
|
Thank you! |
|
@all-contributors please add @enrikb for code, maintenance, ideas |
|
I've put up a pull request to add @enrikb! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
declare firmware_version extern in fido2/version.h
declare RK_STORE 'weak' in fido2/device.c, like the functions
operating on it
Tested on Ubuntu 20.10 using gcc-9 and gcc-10.