Fixing counter increment in ctap_filter_invalid_credentials() #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you and good catch! Merging and testing now. |
|
@all-contributors please add @dmpiergiacomo code, bug |
|
I've put up a pull request to add @dmpiergiacomo! 🎉 |
|
Thank you for adding me to the list of contributors, very appreciated 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes some issues with the fido2-tests. Specifically it fixes:
getAssertionState.user_verifiedis no longer mistakenly set to 0 due to a wrong size used during the memmove().Notice that the tests still fail due to design choices ("Initial SoloKeys model truncates displayName").
I'm currently testing the PC (UDP) version without hardware needed (version 4.0.0).