Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self-update doesn't update session's state #33

Open
solrudev opened this issue Oct 29, 2023 · 3 comments
Open

Self-update doesn't update session's state #33

solrudev opened this issue Oct 29, 2023 · 3 comments
Labels
bug Something isn't working infeasible Can't be done

Comments

@solrudev
Copy link
Owner

solrudev commented Oct 29, 2023 •
edited
Loading

When a self-update is performed through Ackpine, session's state doesn't get updated and is stuck as COMMITTED.

The problem lies in full process stop. SESSION_BASED installer's BroadcastReceiver is not getting invoked when containing package is replaced, while INTENT_BASED installer's Activity can't receive result after full stop. It's possible to receive MY_PACKAGE_REPLACED event, but one can't determine which Ackpine session caused it.
@solrudev solrudev added the bug Something isn't working label Oct 29, 2023
solrudev added a commit that referenced this issue Jan 6, 2024
@solrudev
complete SessionBasedInstallSession if it's a self-update which succe…
dee3264 
…eded

partially fixes #33
solrudev added a commit that referenced this issue Jan 6, 2024
@solrudev
complete SessionBasedInstallSession if it's a self-update which succe…
2c245c1 
…eded

partial fix for #33
@solrudev
Copy link
Owner Author

solrudev commented Jan 6, 2024

Partial fix (for SESSION_BASED package installer sessions) is released in 0.4.1 through 2c245c1.

solrudev added a commit that referenced this issue Oct 12, 2024
@solrudev
(almost) fix of #33 for intent-based sessions
156400f
@solrudev
Copy link
Owner Author

solrudev commented Oct 12, 2024 •
edited
Loading

An (almost) fix is released in 0.7.6 through 156400f.

@solrudev
Copy link
Owner Author

solrudev commented Oct 12, 2024 •
edited
Loading

It seems that full fix of the issue is impossible for INTENT_BASED sessions. But if you have any ideas on how to tackle this issue, feel free to discuss it here or submit a PR.

@solrudev solrudev added the infeasible Can't be done label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working infeasible Can't be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@solrudev