Merge pull request #119 from somleng/fix_release_please

fix: release please
somleng · Dec 19, 2023 · 5e6633e · 5e6633e
2 parents 7598358 + d33eec2
commit 5e6633e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -32,12 +32,15 @@ jobs:
           twilio_version=$(npm info twilio version | xargs echo)
           echo "twilio_version=$twilio_version" >> $GITHUB_OUTPUT
 
+      - name: "Set release version"
+        run: |
+          cat release-please-config.json | jq '. + { "release-as": "${{ steps.get_release_version.outputs.twilio_version }}" }' > release-please-config.json
+
       - uses: google-github-actions/release-please-action@v4
         id: release
         with:
-          release-type: node
-          release-as: ${{ steps.get_release_version.outputs.twilio_version }}
           token: ${{ secrets.SOMLENG_PERSONAL_ACCESS_TOKEN }}
+          config-file: release-please-config.json
 
       - uses: actions/checkout@v4
         if: ${{ steps.release.outputs.release_created }}

diff --git a/.release-please-manifest.json b/.release-please-manifest.json
@@ -1,3 +0,0 @@
-{
-  ".": "4.21.1"
-}

diff --git a/release-please-config.json b/release-please-config.json
@@ -1,9 +1,9 @@
 {
   "packages": {
     ".": {
-      "changelog-path": "CHANGELOG.md",
-      "release-type": "node"
+      "changelog-path": "CHANGELOG.md"
     }
   },
+  "release-type": "node",
   "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
 }