Fix: display errors in reset template #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
previously approved these changes
Jun 11, 2020
core23
requested changes
Jun 11, 2020
| @@ -48,6 +48,7 @@ file that was distributed with this source code. | |||
| 'class': 'form-control', | |||
| 'placeholder': 'form.new_password'|trans({}, 'FOSUserBundle') | |||
| }}) }} | |||
| {{ form_errors(form.plainPassword.first) }} | |||
There was a problem hiding this comment.
Please add this for the second as well
There was a problem hiding this comment.
I think there is not need, check RepeatedTypeValidatorExtension.
There was a problem hiding this comment.
It depends, what other validation was added by the developer.
Currently the reset form do not display errors message. I have added a line after the form widget for display errors messages. The best would be to replace form widget with a form row to display bootstrap template.
jordisala1991
approved these changes
Jun 12, 2020
core23
approved these changes
Jun 12, 2020
fancyweb
approved these changes
Jun 12, 2020
|
Thank you @clementlefrancois |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Currently the reset form do not display errors message.
I have added a line after the form widget for display errors messages.
The best would be to replace form widget with a form row to display bootstrap template.
I am targeting this branch, because this is a bug fix.
Closes #1179
Changelog