Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sonata_user_already_authenticated was not being translated (#1265) #1266

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Fix: sonata_user_already_authenticated was not being translated (#1265) #1266

merged 1 commit into from
Oct 31, 2020

Conversation

BitScout
Copy link
Contributor

@BitScout BitScout commented Oct 28, 2020

Subject

Fixes the problem of the message "sonata_user_already_authenticated" not being translated.
The message is triggered when going to the login page while logged in.

I am targeting this branch, because it is the current version and this is where the bug was found.

Closes #1265.

Changelog

### Fixed
- Fixed the problem of the message "sonata_user_already_authenticated" not being translated.

mazsudo
mazsudo previously approved these changes Oct 28, 2020
src/Action/LoginAction.php Outdated Show resolved Hide resolved
@franmomu
Copy link
Member

franmomu commented Oct 30, 2020

And can you please add a NEXT_MAJOR comment above the constructor like this:

// NEXT_MAJOR: Make $translator argument mandatory.
public function __construct(

So we don't miss it in 5.x.

@VincentLanglet VincentLanglet merged commit 28d4899 into sonata-project:4.x Oct 31, 2020
@VincentLanglet
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sonata_user_already_authenticated no longer translated
5 participants