Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for php 8 and twig 3 #1396

Merged
merged 3 commits into from
Aug 30, 2021
Merged

Add support for php 8 and twig 3 #1396

merged 3 commits into from
Aug 30, 2021

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Aug 30, 2021 •
edited
Loading

Subject

I am targeting this branch, because this is BC. It can be applied now because of latest release of fos/user-bundle.

Closes #1354 .
Closes #1393 .
Closes #1341 .

Changelog

### Added
- Added support for PHP 8.0
- Added support for Twig 3
- Added support for Symfony `http-foundation` 5.3

### Removed
- Removed support for Symfony 5.1 and 5.2

@jordisala1991
Copy link
Member Author

Needs: sonata-project/dev-kit#1649 too.

@jordisala1991 jordisala1991 requested review from VincentLanglet and a team August 30, 2021 10:36
@jordisala1991 jordisala1991 mentioned this pull request Aug 30, 2021
Merged
wbloszyk
wbloszyk previously approved these changes Aug 30, 2021
View reviewed changes
@wbloszyk wbloszyk requested a review from a team August 30, 2021 10:48
@wbloszyk wbloszyk requested a review from a team August 30, 2021 12:01
@VincentLanglet VincentLanglet merged commit eaf3380 into sonata-project:4.x Aug 30, 2021
@VincentLanglet
Copy link
Member

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbloszyk wbloszyk wbloszyk approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does the user bundle require PHP 7.3 and only 7.3? Not compatible with twig 3
3 participants
@jordisala1991 @VincentLanglet @wbloszyk