Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nelmio v4 from conflict #1426

Merged

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented Oct 30, 2021

Subject

I am targeting this branch, because this change should be done here.

Changelog

### Removed
- Removed conflict with `nelmio/api-doc-bundle` v4

@wbloszyk wbloszyk requested a review from phansys October 30, 2021 12:39
composer.json Outdated Show resolved Hide resolved
src/DependencyInjection/SonataUserExtension.php Outdated Show resolved Hide resolved
wbloszyk and others added 2 commits October 30, 2021 17:15
Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
@wbloszyk wbloszyk requested a review from phansys October 30, 2021 15:16
@wbloszyk
Copy link
Member Author

In cases when people using API and havent defind nelmio version in own composer then v4 will be installed. Aby idea haw resole it?
@phansys @sonata-project/contributors

@phansys
Copy link
Member

phansys commented Oct 30, 2021

In cases when people using API and havent defind nelmio version in own composer then v4 will be installed. Aby idea haw resole it?

Why the package will be installed in that case? IIUC, in your example the package is not required by the userland project, and neither is it required by "sonata-project/user-bundle".
Or do you mean the userland project requiring something like "sonata-project/user-bundle": "*"?
If it is the case, I think is responsibility of the user to get rid about the resolved dependencies when performing an update, as the problem there is the loose constraint.

@wbloszyk wbloszyk marked this pull request as ready for review October 30, 2021 18:21
@wbloszyk wbloszyk requested a review from a team October 30, 2021 18:22
@VincentLanglet VincentLanglet requested a review from a team October 30, 2021 18:43
@VincentLanglet VincentLanglet merged commit 2b5ec96 into sonata-project:4.x Oct 30, 2021
@VincentLanglet
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants