-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ReST API #1439
Deprecate ReST API #1439
Conversation
Same was applied for other bundles. Once merged, merged to 5.x and removed deprecated messages, we can deprecate DatagridBundle safely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add upgrade note? https://github.com/sonata-project/SonataPageBundle/pull/1365/files#diff-c698cbb1f2afce655c27e32ebfc8d9f37af04b8164a1d8d609da71d2858c6697
And also be consider and add NEXT_MAJOR
to whole @deprecated
.
883a451
to
bc06e3f
Compare
bc06e3f
to
3d32fc7
Compare
Done, Added upgrade note and added more next major comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add NEXT_MAJOR to removeable PageableInterface in
https://github.com/sonata-project/SonataUserBundle/blob/8885f677e0dfde1e02d88f3ec0b48c2dd8dfa8c5/src/Model/UserManagerInterface.php
https://github.com/sonata-project/SonataUserBundle/blob/8885f677e0dfde1e02d88f3ec0b48c2dd8dfa8c5/src/Model/GroupManagerInterface.php
And need to deprecate and add a NEXT_MAJOR for getPager
method
SonataUserBundle/src/Entity/UserManager.php
Line 119 in 8885f67
public function getPager(array $criteria, int $page, int $limit = 10, array $sort = []): PagerInterface |
public function getPager(array $criteria, int $page, int $limit = 10, array $sort = []): PagerInterface |
public function getPager(array $criteria, int $page, int $limit = 10, array $sort = []): PagerInterface |
public function getPager(array $criteria, int $page, int $limit = 10, array $sort = []): PagerInterface |
This allow to remove the datagridBundle dependency
This PR will allow to close sonata-project/dev-kit#1465 :) |
I already added all deprecations, can you point where it is missing? Both entity folder and model folder are already done. |
Sorry, I need glasses. |
I will try the merge and the code removal later |
Subject
I am targeting this branch, because this is BC.
Changelog