Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ReST API #1439

Merged

Conversation

jordisala1991
Copy link
Member

Subject

I am targeting this branch, because this is BC.

Changelog

### Deprecated
- Deprecated ReST API with FOSRest, Nelmio Api Docs and JMS Serializer.

@jordisala1991 jordisala1991 requested a review from a team December 4, 2021 09:08
@jordisala1991
Copy link
Member Author

Same was applied for other bundles. Once merged, merged to 5.x and removed deprecated messages, we can deprecate DatagridBundle safely.

Copy link
Member

@wbloszyk wbloszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordisala1991
Copy link
Member Author

Can you add upgrade note? https://github.com/sonata-project/SonataPageBundle/pull/1365/files#diff-c698cbb1f2afce655c27e32ebfc8d9f37af04b8164a1d8d609da71d2858c6697

And also be consider and add NEXT_MAJOR to whole @deprecated.

Done, Added upgrade note and added more next major comments.

@jordisala1991 jordisala1991 requested review from wbloszyk and a team December 4, 2021 09:36
@wbloszyk wbloszyk requested a review from a team December 4, 2021 09:39
Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add NEXT_MAJOR to removeable PageableInterface in
https://github.com/sonata-project/SonataUserBundle/blob/8885f677e0dfde1e02d88f3ec0b48c2dd8dfa8c5/src/Model/UserManagerInterface.php
https://github.com/sonata-project/SonataUserBundle/blob/8885f677e0dfde1e02d88f3ec0b48c2dd8dfa8c5/src/Model/GroupManagerInterface.php

And need to deprecate and add a NEXT_MAJOR for getPager method

public function getPager(array $criteria, int $page, int $limit = 10, array $sort = []): PagerInterface

public function getPager(array $criteria, int $page, int $limit = 10, array $sort = []): PagerInterface

public function getPager(array $criteria, int $page, int $limit = 10, array $sort = []): PagerInterface

public function getPager(array $criteria, int $page, int $limit = 10, array $sort = []): PagerInterface

This allow to remove the datagridBundle dependency

@VincentLanglet
Copy link
Member

This PR will allow to close sonata-project/dev-kit#1465 :)

@jordisala1991
Copy link
Member Author

I already added all deprecations, can you point where it is missing? Both entity folder and model folder are already done.

@VincentLanglet
Copy link
Member

I already added all deprecations, can you point where it is missing? Both entity folder and model folder are already done.

Sorry, I need glasses.

@jordisala1991 jordisala1991 merged commit bf1d08e into sonata-project:4.x Dec 4, 2021
@jordisala1991 jordisala1991 deleted the feature/deprecate-api branch December 4, 2021 13:10
@jordisala1991
Copy link
Member Author

I will try the merge and the code removal later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants