Fix invalid ISO 8601 datetime fomat #51
Conversation
|
Please add to the test (Iso8601DateTest) what is expected. |
|
@basil3whitehouse Yes, will do. |
SimpleDateFormat used Z as timezone, though this is invalid because it is a RFC timezone and not an ISO 8601 timezone. Use XXX format for ISO-compliant timezone format.
|
@basil3whitehouse I have added another test with Zulu timezone. I did not add another one because it won't get a test stable w/o some effort due to changing offsets and DSTs. Such a test would be brittle. |
| assertNotNull(date); | ||
|
|
||
| TimeZone savedTimeZone = TimeZone.getDefault(); | ||
| TimeZone zuluTimeZone = TimeZone.getTimeZone("Etc/UTC"); |
There was a problem hiding this comment.
I was going to make a comment here about finding and using a constant, but decided to check online and make sure that constants existed... shame on you, Java, for not having constants for timezone IDs!
|
Anymore willing to merge after all? |
|
anyone? |
|
@michael-o , hi there, I got sent this, and I'm so sorry it has taken so long for someone to reply! I don't really actively monitor this repo, so I completely missed it. @bhamail and I can likely get this over the hump. Do me a favor, go and sign our CLA here, and let me know when you have. Once you have, I'll get this merged with someone! https://sonatypecla.herokuapp.com/sign-cla |
|
@DarthHater Signed CLA, please check. |
|
@michael-o we are circulating this to the internal team to see what it impacts (since it's consumed further down the chain). Thank you! Sorry again for how long it's taken, I appreciate your contribution! |
|
Thanks @michael-o I'm going to try to do some dependency updates and release in the next week. |
|
@michael-o I forgot to post this but I published 2.3.2-01 - https://search.maven.org/artifact/org.sonatype.goodies/goodies/2.3.2-01/pom |
SimpleDateFormat used Z as timezone, though this is invalid because it is a RFC
timezone and not an ISO 8601 timezone. Use XXX format for ISO-compliant timezone
format.