Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a release pipeline #61

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Conversation

wwannemacher
Copy link
Contributor

not sure if it's appropriate to make this a PR - I can't really test it until it's on master. Additionally, once it is on master, if I run into issues, I may make the changes directly on the master branch...

However, the goal here is to keep this file as slim as possible - problems will more than likely dictate changes in the jenkins-shared library.

All of that being said, I'd consider this PR to be a heads-up that I'm going to test releases of these jars on jenkins, using the attached pipeline.

Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge and go ahead with testing

(I assume the test release is going to go to staging on RSO and then be dropped, so it won't necessitate anything going to central)

@wwannemacher
Copy link
Contributor Author

I am pretty sure that it will get staged, here is the snippet from the effective-pom:

    <distributionManagement>
      <repository>
        <id>sonatype-public</id>
        <url>https://repository.sonatype.org/service/local/staging/deploy/maven2</url>
      </repository>
      <snapshotRepository>
        <id>sonatype-public</id>
        <url>https://repository.sonatype.org/content/repositories/snapshots</url>
      </snapshotRepository>
    </distributionManagement>

In the settings.xml file on jenkins I do not see a server entry with sonatype-public as the ID. I also did not see anything in the jenkins-shared repo. So, I think that it will try to stage the release and fail. It's possible that git tags may be created in the process. If so, I will try to manually clean up if necessary.

@wwannemacher
Copy link
Contributor Author

the staging plugin configuration also points to <serverId>sonatype-public</serverId>

Anyhow, I'll just have to try and see what happens.

@wwannemacher wwannemacher merged commit 6f1a580 into master Jun 1, 2018
@wwannemacher wwannemacher deleted the release-testing-on-jenkins branch June 1, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants