[dash-p4] Refactor incoming packet encap handling and inbound routing stage. #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r12f
force-pushed
the
user/r12f/inbound-routing
branch
from
fd8f88f to
ab5c2be
Compare
|
Does this need a reviewer @r12f ? Let me know if I can help... |
|
yea, I have added Marian in the PR. Let's see how it goes. |
|
Thanks Kristina. |
r12f
force-pushed
the
user/r12f/inbound-routing
branch
2 times, most recently
from
fd54544 to
d1f33be
Compare
KrisNey-MSFT
added
help wanted
r12f
force-pushed
the
user/r12f/inbound-routing
branch
2 times, most recently
from
bc3dbbf to
f843645
Compare
marian-pritsak
approved these changes
Jul 13, 2024
|
@r12f - looks good to reviewer, if you'd like to take a look |
|
@r12f - looks like this has branch conflicts now - we will wait for you to return from your OOF. |
|
checking in here @r12f |
r12f
force-pushed
the
user/r12f/inbound-routing
branch
from
f843645 to
fa2444a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, several stages / tables in DASH directly uses the headers to lookup entries, such as direction. inbound routing, and etc. It it ok currently, because DASH only accepts traffic with a single layer and a single type of encap. However, once we start to handle multiple layers and types of encaps, it will make the pipeline very complicated.
This change refactors the pipeline to add a pre-pipeline stage to preprocess the underlay and overlay data for pipeline lookup and actions, so we can keep the rest of the pipeline more future-proof.