Update README.md #614
Closed
Update README.md #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With more P4, PNA, bmv2 info
| @@ -33,6 +33,7 @@ This is a P4 model of the DASH overlay pipeline which uses the [bmv2](https://gi | |||
| - [Install docker compose](#install-docker-compose) | |||
|
|
|||
| # Known Issues | |||
| * The issue with P4 behavioral model is that it is hardware agnostic. P4-16 has very basic constructs and the consortium left it the hardware vendors to define all else as extern. For example: simple things like checksums are now extern. Running a P4 program written for a specific hardware will not compile for BMv2 unless all externs used in the P4 program as implemented for BMv2. PNA (Portable NIC Architecture) is an attempt at standardizing the externs to enable code to work across vendors. | |||
| * P4 code doesn't loop packets back to same port. | |||
| * P4 code mark-to-drop not set when meta.drop is set. | |||
| * Permission and ownership issues in Docker images, permanent fix is needed. | |||
There was a problem hiding this comment.
Could you delete this line? It was addressed more than a year ago.
| @@ -33,6 +33,7 @@ This is a P4 model of the DASH overlay pipeline which uses the [bmv2](https://gi | |||
| - [Install docker compose](#install-docker-compose) | |||
|
|
|||
| # Known Issues | |||
| * The issue with P4 behavioral model is that it is hardware agnostic. P4-16 has very basic constructs and the consortium left it the hardware vendors to define all else as extern. For example: simple things like checksums are now extern. Running a P4 program written for a specific hardware will not compile for BMv2 unless all externs used in the P4 program as implemented for BMv2. PNA (Portable NIC Architecture) is an attempt at standardizing the externs to enable code to work across vendors. | |||
There was a problem hiding this comment.
I don't understand how this is an "issue." AFAIK it isn't an objective to have code for DASH bmv2 run on HW or vice versa.
|
Will do...
From: Chris Sommers ***@***.***>
Sent: Friday, August 9, 2024 10:25 AM
To: sonic-net/DASH ***@***.***>
Cc: Kristina Moore ***@***.***>; Author ***@***.***>
Subject: Re: [sonic-net/DASH] Update README.md (PR #614)
@chrispsommers commented on this pull request.
________________________________
In dash-pipeline/README.md<#614 (comment)>:
@@ -33,6 +33,7 @@ This is a P4 model of the DASH overlay pipeline which uses the [bmv2](https://gi
- [Install docker compose](#install-docker-compose)
# Known Issues
+* The issue with P4 behavioral model is that it is hardware agnostic. P4-16 has very basic constructs and the consortium left it the hardware vendors to define all else as extern. For example: simple things like checksums are now extern. Running a P4 program written for a specific hardware will not compile for BMv2 unless all externs used in the P4 program as implemented for BMv2. PNA (Portable NIC Architecture) is an attempt at standardizing the externs to enable code to work across vendors.
* P4 code doesn't loop packets back to same port.
* P4 code mark-to-drop not set when meta.drop is set.
* Permission and ownership issues in Docker images, permanent fix is needed.
Could you delete this line? It was addressed more than a year ago.
-
Reply to this email directly, view it on GitHub<#614 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJSI6GRM2DL6LE2BH5EWTDZQT3QTAVCNFSM6AAAAABMIZETVKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZQG4YDSMBWGU>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
|
not necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With more P4, PNA, bmv2 info