Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMIS_and_C-CMIS_support_for_ZR.md #1076

Merged
merged 439 commits into from
Oct 31, 2022

Conversation

qinchuanares
Copy link
Contributor

The markdown file "CMIS_and_C-CMIS_support_for_ZR.md" describes the work to provide CMIS and C-CMIS support on 400G ZR, a new generation of coherent optical modules to run on SONiC platforms. The markdown article focuses on how to access the registers with the definitions given in CMIS and C-CMIS documents and to achieve certain high-level tasks/functions at the module level. It breaks the process down to four architectural layers and shows each layer at a high level.

Repo PR Title State
sonic-utilities fix for non-coherent cmis modules Merged
sonic-utilities [sfputil] Firmware download/upgrade CLI support for QSFP-DD Merged
sonic-utilities Add transceiver-info items advertised for cmis-supported moddules Merged
sonic-platform-daemons Include changes from xcvr_api in transceiver_info table Merged
sonic-platform-common Skip CDB and VDM for flat memory modules Merged
sonic-platform-common [CMIS]Fix low-power to high power mode transition Merged
sonic-platform-common Firmware upgrade CLI support for QSFP-DD transceivers Merged
sonic-platform-common fix for firmware functions Merged
sonic-platform-common Gracefully handle CMIS APIs for passive modules Merged
sonic-platform-common code fix for copper cable modules with flat memory Merged
sonic-platform-common 400zr initial support Merged
sonic-platform-daemons Xcvrd changes to support 400G ZR configuration Merged
sonic-utilities portconfig option to configure Tx power and laser frequency of ZR transceiver module Merged
sonic-buildimage Yang model for xcvr tx power and frequency configuration Merged

@zhangyanzhao
Copy link
Collaborator

can we approve and merge this PR? @prgeor

@keboliu
Copy link
Collaborator

keboliu commented Oct 10, 2022

https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md was not updated with new added commands:

config interface transceiver frequency
config interface transceiver tx-power

@zhangyanzhao
Copy link
Collaborator

https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md was not updated with new added commands:

config interface transceiver frequency
config interface transceiver tx-power

@qinchuanares can you please help to address this comments and resolve this after the update? Thanks.

@qinchuanares
Copy link
Contributor Author

https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md was not updated with new added commands:

config interface transceiver frequency
config interface transceiver tx-power

I updated this md file Section 2.4 with this commit to reflect the most recent changes on config interface transceiver. 831a150b4580ff874e2134edbcb761d9cb8b8d38

I also proposed change and create a PR in https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md

sonic-net/sonic-utilities#2437

@qinchuanares
Copy link
Contributor Author

https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md was not updated with new added commands:

config interface transceiver frequency
config interface transceiver tx-power

@qinchuanares can you please help to address this comments and resolve this after the update? Thanks.

Done with comments. New commits into this PR and I opened a new PR in the reference md document.

@prgeor
Copy link
Contributor

prgeor commented Oct 12, 2022

https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md was not updated with new added commands:

config interface transceiver frequency
config interface transceiver tx-power

@qinchuanares please update the CLI as per this PR https://github.com/sonic-net/sonic-utilities/pull/2197/files. I agree with @keboliu

module_media_type and type_abbrv_name are not in state_db TRANSCEIVER_INFO table. Both are removed.
@zhangyanzhao
Copy link
Collaborator

https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md was not updated with new added commands:

config interface transceiver frequency
config interface transceiver tx-power

@qinchuanares please update the CLI as per this PR https://github.com/sonic-net/sonic-utilities/pull/2197/files. I agree with @keboliu

@qinchuanares this comments need be addressed, can you please help? Thanks.

@qinchuanares
Copy link
Contributor Author

https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md was not updated with new added commands:

config interface transceiver frequency
config interface transceiver tx-power

@qinchuanares please update the CLI as per this PR https://github.com/sonic-net/sonic-utilities/pull/2197/files. I agree with @keboliu

@qinchuanares this comments need be addressed, can you please help? Thanks.

I already addressed the issue and merged this PR: sonic-net/sonic-utilities#2437


- Example (bring module up from low power mode, or bring down module to low power mode):
```
admin@sonic:~# config interface transceiver lpmode Ethernet0 -- enable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'--' is NOT required in the CLI

admin@sonic:~# config interface transceiver lpmode Ethernet0 -- enable
Enabling low-power mode for port Ethernet0 ... OK

admin@sonic:~# config interface transceiver lpmode Ethernet0 -- disable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'-- is NOT required in the CLI


- Example (config the privisioning frequency):
```
admin@sonic:~# config interface transceiver frequency Ethernet0 -- 196025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'--' is NOT required in this CLI


- Example (config the loopback mode):
```
admin@sonic:~$ config interface transceiver loopback Ethernet0 -- none
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'--' is NOT required

@prgeor prgeor merged commit e2b844e into sonic-net:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants