-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMIS_and_C-CMIS_support_for_ZR.md #1076
Add CMIS_and_C-CMIS_support_for_ZR.md #1076
Conversation
can we approve and merge this PR? @prgeor |
https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md was not updated with new added commands:
|
@qinchuanares can you please help to address this comments and resolve this after the update? Thanks. |
I updated this md file Section 2.4 with this commit to reflect the most recent changes on config interface transceiver. 831a150b4580ff874e2134edbcb761d9cb8b8d38 I also proposed change and create a PR in https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md |
Done with comments. New commits into this PR and I opened a new PR in the reference md document. |
@qinchuanares please update the CLI as per this PR https://github.com/sonic-net/sonic-utilities/pull/2197/files. I agree with @keboliu |
module_media_type and type_abbrv_name are not in state_db TRANSCEIVER_INFO table. Both are removed.
@qinchuanares this comments need be addressed, can you please help? Thanks. |
I already addressed the issue and merged this PR: sonic-net/sonic-utilities#2437 |
|
||
- Example (bring module up from low power mode, or bring down module to low power mode): | ||
``` | ||
admin@sonic:~# config interface transceiver lpmode Ethernet0 -- enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'--' is NOT required in the CLI
admin@sonic:~# config interface transceiver lpmode Ethernet0 -- enable | ||
Enabling low-power mode for port Ethernet0 ... OK | ||
|
||
admin@sonic:~# config interface transceiver lpmode Ethernet0 -- disable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'-- is NOT required in the CLI
|
||
- Example (config the privisioning frequency): | ||
``` | ||
admin@sonic:~# config interface transceiver frequency Ethernet0 -- 196025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'--' is NOT required in this CLI
|
||
- Example (config the loopback mode): | ||
``` | ||
admin@sonic:~$ config interface transceiver loopback Ethernet0 -- none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'--' is NOT required
The markdown file "CMIS_and_C-CMIS_support_for_ZR.md" describes the work to provide CMIS and C-CMIS support on 400G ZR, a new generation of coherent optical modules to run on SONiC platforms. The markdown article focuses on how to access the registers with the definitions given in CMIS and C-CMIS documents and to achieve certain high-level tasks/functions at the module level. It breaks the process down to four architectural layers and shows each layer at a high level.