teamd warm-restart in fast mode hld #1095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tianshangfei <tian_shangfei@163.com>
Signed-off-by: tianshangfei <tian_shangfei@163.com>
tianshangfei
force-pushed
the
teamd_warmrestart1
branch
from
f867761 to
ea669fa
Compare
tianshangfei
force-pushed
the
teamd_warmrestart1
branch
from
59741c2 to
5f1326f
Compare
tianshangfei
force-pushed
the
teamd_warmrestart1
branch
from
3fccfd9 to
ff0b7da
Compare
Signed-off-by: tianshangfei <tian_shangfei@163.com>
tianshangfei
force-pushed
the
teamd_warmrestart1
branch
from
9d9a09c to
cda2dae
Compare
|
HLD was reviewed on Oct 11, 2022. @tianshangfei can you please help to add the code PRs to this HLD? Thanks. |
The code PR is not ready yet, and the implementation has been delayed because some urgent work needs to be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect that the restart of teamd docker should not cause link flapping or any traffic loss. All lags at data plane should remain the same. But it's hard to implement in some scenarios.
During teamd warm-restart, the control plane remains up for a maximum of 90 seconds in LACP slow mode. However, in LACP fast mode, the control plane can only remain up for 3 seconds. This is because LACPDUs are sent every second. LACP protocol considers a LAG to be down if three LACPDUs are not received.
Teamd containers are not restarted that fast, so teamd warm-restart in LACP fast mode always results in lag down and the kernel LAG state in mess. However, in a data center, it is necessary to set LACP to fast mode to ensure faster link convergence and less traffic loss.
Therefore, supporting teamd warm-restart in LACP fast mode is very important. With this feature, we can support teamd bug hotfix and smooth upgrades.
This design supports teamd warm-restart in fast mode by switching between active and standby teamd container.
Signed-off-by: tianshangfei tian_shangfei@163.com