-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expected output for transceiver DOM CLI #1306
Conversation
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@prgeor @qinchuanares @keboliu @shyam77git - It will be great if you can help in review this. |
In PR sonic-net/sonic-utilities#2630 "show interfaces transceiver info {interface}" was added as a warper to "sfpshow eeprom -p {interface}", will this command be a similar case? a wraper to "sfpshow eeprom -p {interface} --dom"? |
@keboliu We plan to deprecate "sfpshow eeprom" in future and use "show interfaces transceiver info {interface}" or "show interfaces transceiver dom {interface}" for dumping EEPROM info or DOM related information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mihirpat1 approving with minor comment
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@longhuan-cisco to please review this |
Add the expected output for
show interfaces transceiver dom <port>
CLI for all types of transceivers.Overall, this CLI will display the real time values and threshold data for the DOM sensors on the particular SFP. The CLI is planned to read data from TRANSCEIVER_DOM_SENSOR and TRANSCEIVER_DOM_THRESHOLD STATE_DB tables.
The current output is classified in 3 sections.
Section 1 will be displayed for all transceivers.
Section 2 will be displayed only if the transceiver is CMIS or C_CMIS based
Section 3 will be displayed only if the transceiver is C_CMIS based