Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asic_thermal_monitoring_hld.md #1841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions doc/asic_thermal_monitoring_hld.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Rev | Rev Date | Author | Change Description
|v0.1 |01/10/2019 |Padmanabhan Narayanan | Initial version
|v0.2 |10/07/2020 |Padmanabhan Narayanan | Update based on review comments and addess Multi ASIC scenario.
|v0.3 |10/15/2020 |Padmanabhan Narayanan | Update Section 6.3 to indicate no change in thermalctld or Platform API definitions.
|v0.4 |10/29/2024 |Judy Joseph | Add section 6.3.1 to propose a way to generate the asic_sensor config in DB


## 2. Scope
ASICs typically have multiple internal thermal sensors. This document describes the high level design of a poller for ASIC thermal sensors. It details how the poller may be configured and the export of thermal values from SAI to the state DB.
Expand Down Expand Up @@ -113,6 +115,18 @@ The implementation of the APIs get_high_threshold(), get_low_threshold(), get_hi

The thermalctld's TemperatureUpdater::_refresh_temperature_status() retreives the temperatures of the ASIC internal sensors from the get_temperature() API - just as it would for any external sensor. Only that in the case of ASIC internal sensors, the get_temperature() API is going to retrieve and return the value from from ASIC_TEMPERATURE_INFO table. The thermalctld also updates these values to the TEMPERATURE_INFO table in the globalDB's stateDB. Thus, there is no change in the existing thermalctld infrastructure.

#### 6.3.1 Generate the config in the config_db

Platform owners can define the following in the respective platform.json file, which could be parsed during config load_minigraph/reload to push the ASIC_SENSORS ConfigDB table entry in the DB

```
"asic_sensors": {
"poll_interval": "10",
"poll_admin_status": "enable"
}
```


## 7 Virtual Switch

NA
Expand Down