Minor fixes for reboot HLD

[vvolam]

• Add more details for MODULE_REBOOT_SMARTSWITCH reboot type
• Update DPU and Switch reboot sequence with PCI detach/reattach() vendor APIs
• Remove module name from module APIs
• Remove the tests which were missed removing from first HLD PR.

[mssonicbld]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[rameshraghupathy]

Looks good to me.

[prgeor]

@vvolam consider a case where NPU was rebooted do we have check in place to detect whether NPU actually rebooted once the NPU comes up?

[vvolam]

@vvolam consider a case where NPU was rebooted do we have check in place to detect whether NPU actually rebooted once the NPU comes up?

@prgeor Once the system issues the reboot command, it is exiting the context based on my understanding. We can only check the switch state in our test scripts. Please correct me, if I missing any thing here?

[prgeor]

@vvolam consider a case where NPU was rebooted do we have check in place to detect whether NPU actually rebooted once the NPU comes up?

@prgeor Once the system issues the reboot command, it is exiting the context based on my understanding. We can only check the switch state in our test scripts. Please correct me, if I missing any thing here?

@vvolam consider a case where NPU was rebooted do we have check in place to detect whether NPU actually rebooted once the NPU comes up?

@prgeor Once the system issues the reboot command, it is exiting the context based on my understanding. We can only check the switch state in our test scripts. Please correct me, if I missing any thing here?

@vvolam you don't need current context to check but there are different ways in which you can do.

1. NPU can put a marker for each DPU and check if the marker exist while NPU comes up
2. NPU can check the uptime of DPU before rebooting and know whether it rebooted

I think we can probably keep this for future

[vvolam]

@vvolam consider a case where NPU was rebooted do we have check in place to detect whether NPU actually rebooted once the NPU comes up?

@prgeor Once the system issues the reboot command, it is exiting the context based on my understanding. We can only check the switch state in our test scripts. Please correct me, if I missing any thing here?

@vvolam consider a case where NPU was rebooted do we have check in place to detect whether NPU actually rebooted once the NPU comes up?

@prgeor Once the system issues the reboot command, it is exiting the context based on my understanding. We can only check the switch state in our test scripts. Please correct me, if I missing any thing here?

@vvolam you don't need current context to check but there are different ways in which you can do.

1. NPU can put a marker for each DPU and check if the marker exist while NPU comes up
2. NPU can check the uptime of DPU before rebooting and know whether it rebooted

I think we can probably keep this for future
@prgeor Sure, I will keep a note on this to enhance the HLD for this. Thank you!

[prgeor]

@vvolam in the Test Plan section there is this rendered text with ### is that intentional?

###Graceful boot/reboot###

[vvolam]

@vvolam in the Test Plan section there is this rendered text with ### is that intentional?

###Graceful boot/reboot###

It was a syntax error. Fixed it. Thank you!