-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layer 2 forwarding enhancements HLD #379
Conversation
The documents decribes the functional spec and high level design for Layer 2 Forwarding Enhancements.
Changed FDB flush mechanism from individual FDB entry delete to Bulk flush in hardware.
Updated to exclude bridge_port_id in Orchagent FDB data structure as it is not needed for bulk flush. We only need the FDB type.
some minor corrections.
Could you also help to fix CLI "show mac" takes too much time to display mac entries, e.g. It will take more than 30+ mins to display 32K entries output? Thanks! Wilson @loshihyu |
Hi Wilson,
We are able to bring this time down significantly. We will share the fix
with community.
Thanks.
Anil
…On Tue, May 21, 2019 at 1:31 PM Chain-Wu Lee ***@***.***> wrote:
Could you also help to fix CLI "show mac" takes too much time to display
mac entries, e.g. It will take more than 30+ mins to display 32K entries
output? Thanks!
Wilson
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#379>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALLPOUJDQ6WFRHBQSM5YQO3PWRLY3ANCNFSM4HLWJRCQ>
.
|
That's great! Thanks Anil! Wilson |
1. Added per port per VLAN fdb clear option. 2. Listed all the SAI attributes being used. 3. Added -w option in VLAN Range commands to indicate logging of warning messages.
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you remove all the .DS_Store files?
Done |
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Outdated
Show resolved
Hide resolved
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Outdated
Show resolved
Hide resolved
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
Updated default FDB aging time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also check other reviewers' comments
@keboliu , @madhupalu , can you review/approve this?. Looks like all the open comments are addressed. |
* Layer 2 Forwarding Enhancements FDS The documents decribes the functional spec and high level design for Layer 2 Forwarding Enhancements. * Layer 2 Forwarding Enhancements HLD * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update .DS_Store * Update .DS_Store * Updated to change FDB flush as bulk flush in hardware Changed FDB flush mechanism from individual FDB entry delete to Bulk flush in hardware. * exclude bridge_port_id in fdb data structure Updated to exclude bridge_port_id in Orchagent FDB data structure as it is not needed for bulk flush. We only need the FDB type. * exclude bridge_port_id in fdb data structure * Update SONiC Layer 2 Forwarding Enhancements HLD.md some minor corrections. * Updated with inputs from community review 1. Added per port per VLAN fdb clear option. 2. Listed all the SAI attributes being used. 3. Added -w option in VLAN Range commands to indicate logging of warning messages. * remove .DS_Store * Update SONiC Layer 2 Forwarding Enhancements HLD.md Updated default FDB aging time.
Hi Anil, Are there any plans to write ansible or pytest scripts to test those enhancements. @anilkpandey Thanks. |
Hi William, pytest scripts are added as part of the following PR: |
Hi Anil, It seems you have added some VS tests to test this enhancements. I also want to know if there are any plans to write test cases for this enhancements in sonic-mgmt Thanks. |
No, only VS pytest. |
Thanks Anil! I see. william-zx |
|
||
|
||
**Changes for Static FDB configuration.** | ||
New CLI will be added for configuring Static FDB entry. It will be set in the FDB_TABLE in CONFIG_DB. Vlanmgr will handle the CONIG_DB changes, do necessary validations and then populate in APP_DB. FdbOrch already has all the necessary handling for Static FDB changes from APP_DB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious When a static FDB entry is removed from CLI, will SAI notify a SAI_FDB_EVENT_AGED to orchagent?
From images/staticMacConfig.jpg, even if such an event is present, orchagent will ignore it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, SAI_FDB_EVENT_AGED will be received and it will be ignored at orchagent because the fdb entry does not exist anymore.
The document provides high level design for enhancements in SONiC layer 2 forwarding for FDB flush, MAC move, FDB aging time configuration, Static FDB configuration and VLAN Range configuration.
PRs:
sonic-net/sonic-sairedis#510
sonic-net/sonic-swss-common#303
sonic-net/sonic-utilities#529
sonic-net/sonic-swss#1716