SONIC broadcast, unknown-unicast and unknown-multicast (BUM) storm-control HLD #441
Conversation
…oadcast, unknown-unicast and unknown-multicast storm-control feature in SONiC
|
|
mohan-selvaraj
changed the title
mohan-selvaraj
changed the title
|
|
||
| ### 3.2.1 CONFIG_DB | ||
| A new table CFG_PORT_STORM_CONTROL_TABLE is introduced in the configuration database for the purpose of storing storm-control configuration parameters. This table is filled by the management framework. | ||
| #### CFG_PORT_STORM_CONTROL_TABLE |
There was a problem hiding this comment.
There was a problem hiding this comment.
Please correct the table name as PORT_STORM_CONTROL and use "|" has key separators in config-DB.
There was a problem hiding this comment.
Updated Table Name.
|
@prsunny to review |
| BUM storm control | ||
| - Configuration is not supported on VLAN and port-channel interfaces. User can configure on physical port which is part of a VLAN / port-channel. | ||
| - Statistics is not supported. | ||
| - User is expected to remove all storm-control configurations from interface before doing a breakout from Click CLI. |
There was a problem hiding this comment.
I think, we do force delete configs during breakout..right?
There was a problem hiding this comment.
Yes. will remove this comment. breakout to be handled in code.
|
|
||
| __Figure 1: Storm Control High Level Architecture__ | ||
|
|
||
| 1) Storm-control configurations are parsed and stored in CFG_PORT_STORM_CONTROL_TABLE in Configuration database by the Management Framework. |
There was a problem hiding this comment.
Update this section to capture SONiC CLI update as well.
There was a problem hiding this comment.
The flow from CONFIG_DB update to backend is already captured.
| This section lists down the Click commands. | ||
| BUM storm-control can be configured only on physical interfaces. | ||
| **switch# config interface storm-control {broadcast | unknown-unicast | unknown-multicast} {add|del} \<interface_name\> {\<kilo_bits_per_second\>}** | ||
|
|
There was a problem hiding this comment.
Suggest to change the SONiC CLI command as follows,
config interface storm-control { add | del } {broadcast | unknown-unicast | unknown-multicast} <kilo_bits_per_second>
There was a problem hiding this comment.
storm-control policer types are keywords. add/del are operations. Keywords are kept in the beginning of the command.
user might want to know the type before performing the operation.
| ### 3.5.3 Show Commands | ||
| The following show command displays storm-control configurations. | ||
|
|
||
| **show storm-control {all | interface \<interface_name\>}** |
There was a problem hiding this comment.
Suggest to use the following format,
show storm-control [interface <interface_name>]
|
Can we add the code PRs by referring to #806 ? |
|
|
||
| ### 1.1.1 Functional Requirements | ||
| 1. Support configuration of Broadcast, Unknown-unicast and unknown-Multicast storm-control independently on physical interfaces. | ||
| 2. Support threshold rate configuration in kilo bits per second (kbps) in the range of 0 kbps to 100,000,000 kbps (100Gbps). |
There was a problem hiding this comment.
Could unit packets per second (pps) also supported along with kilo bits per second (kbps).
There was a problem hiding this comment.
Will try to accomodate the change in the future.
|
@mohan-selvaraj would you please update the code PRs by following template of #806 ? Thanks. |
|
@zhangyanzhao Review is done, pls help push for merge |
…oadcast, unknown-unicast and unknown-multicast storm-control feature in SONiC
PR Tracking Table