[doc] Add L3 drop counters SNMP design #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
qiluo-msft
reviewed
Mar 20, 2020
| | Interface | IANA Iftype | Already implemented? | | ||
| | ---------- |:--------------:| :---------:| | ||
| | port | 6 ethernetCsmacd | + | | ||
| | RIF | - | Need to add to port counters | |
There was a problem hiding this comment.
Need to add to port counters [](start = 19, length = 28)
The words are confusing in the column "Already implemented?". Maybe you could add one more column "Proposed implementation", and clarify exactly what already implemented so we could understand the gaps. #Closed
qiluo-msft
requested changes
Mar 20, 2020
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
qiluo-msft
approved these changes
May 13, 2020
qiluo-msft
reviewed
Jun 2, 2020
|
@lguohan as implementation is already in review, can you please approve so we can merge? |
Implementation is merged already. |
qiluo-msft
approved these changes
Jul 7, 2020
kartik-arista
pushed a commit
to kartik-arista/SONiC
that referenced
this pull request
Jul 16, 2020
* [doc] Add Port_illegal_packets_drop_design * fix comments * Update doc/Port_illegal_packets_drop_design.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Faryma mykolaf@mellanox.com