-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[port_buffer_drop] Add Port buffer drop counters in SONiC doc #658
Conversation
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
## 2.1 Functional Requirements | ||
1. New flex counter group is introduced for the port-level buffer drop counters | ||
2. The FC group is enabled by default | ||
3. The polling interval is 60s by defaul |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/s defaul default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
-------------------------- ------------------ -------- | ||
QUEUE_STAT default (10000) enable | ||
PORT_STAT default (1000) enable | ||
PORT_BUFFER_DROP default (60000) enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to mark the added one comparing to the current implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
### 3.1.3 Setting new polling interval | ||
``` | ||
admin@sonic:~$ counterpoll port-buffer-drop interval 30000 | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have schema update, right? please add it to the design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Port buffer drop counters does not introduce any new schema.
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Add req doc for sonic-net/sonic-swss#1368 as the community requested
Signed-off-by: Mykola Faryma mykolaf@mellanox.com