[HLD] Event Driven TechSupport Invocation & CoreDump Mgmt #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
nazariig
reviewed
Sep 2, 2021
| state = enabled|disabled; # Enable this to make the Techsupport Invocation event driven based on core-dump generation | ||
| rate_limit_interval = 300; # Minimum Time in seconds, between two successive techsupport invocations. | ||
| Manual Invocations will be considered as well in the cooloff calculation | ||
| max_techsupport_size = 10; # A perentage value should be specified. |
There was a problem hiding this comment.
@vivekreddynv typo? Did you mean percentage?
nazariig
reviewed
Sep 2, 2021
| This signifies maximum Size to which /var/dump/ directory can be grown until. | ||
| The actual value in bytes is calculate based on the available space in the filesystem hosting /var/dump | ||
| When the limit is crossed, the older techsupport dumps are incrementally deleted | ||
| max_core_size = 5; # A perentage value should be specified. |
There was a problem hiding this comment.
@vivekreddynv typo? Did you mean percentage?
nazariig
reviewed
Sep 2, 2021
|
|
||
| Where `<comm>` value in the command name associated with a process. comm value of a running process can be read from `/proc/[pid]/comm` file | ||
|
|
||
| ## 4. Schema Additions |
There was a problem hiding this comment.
@vivekreddynv suggest to follow SONiC DB schema description conventions (ABNF):
nazariig
reviewed
Sep 2, 2021
| description "First Revision"; | ||
| } | ||
|
|
||
| typedef enable-knob { |
There was a problem hiding this comment.
@vivekreddynv we already have this type in SONiC:
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-types.yang#L54
typedef admin_status {
type enumeration {
enum up;
enum down;
}
}There was a problem hiding this comment.
I feel "enabled|disabled" makes better sense here over "up|down".
There was a problem hiding this comment.
@vivekreddynv sorry, a typo:
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-types.yang#L119
typedef admin_mode {
type enumeration {
enum enabled;
enum disabled;
}
}There was a problem hiding this comment.
Oh okay, I'll change this
nazariig
reviewed
Sep 2, 2021
| leaf feature_name { | ||
| description "The name of this feature"; | ||
| /* TODO: Leafref once the FEATURE YANG is added*/ | ||
| type string; |
There was a problem hiding this comment.
@vivekreddynv please add a key length constraint
nazariig
previously approved these changes
Sep 2, 2021
This was referenced Sep 3, 2021
ganglyu
approved these changes
Oct 17, 2021
|
@nazariig do you have any further comments? if not can you please approve? |
nazariig
approved these changes
Nov 11, 2021
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Nov 16, 2021
#### What I did sonic-utilities changes required for feature "Event Driven TechSupport Invocation & CoreDump Mgmt". [HLD](sonic-net/SONiC#818 ) Summary of the changes: - Added the AUTO GEN CLI for the CFG DB tables required for this feature - Added the coredump_gen_handler.py & techsupport_cleanup.py scripts. - Added the UT's required for these scripts. - Enhanced coredump-compress & generate-dump scripts
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Nov 16, 2021
#### Why I did it Changes required for feature "Event Driven TechSupport Invocation & CoreDump Mgmt". [HLD](sonic-net/SONiC#818 ) Requires: sonic-net/sonic-utilities#1796. Merging in any order would be fine. Summary of the changes: - Added the YANG Models for the new tables introduces as a part of this feature. - Enhanced init_cfg.json with the default config required - Added a compile Time flag which enables/disables the config required for this feature inside the init_cfg.json - Enhanced the supervisor-proc-exit-listener script to populate `<feature>:<critical_proc> = <comm>:<pid>` info in the STATE_DB when it observes an proc exit notification for the critical processes running inside the docker.
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
#### What I did sonic-utilities changes required for feature "Event Driven TechSupport Invocation & CoreDump Mgmt". [HLD](sonic-net/SONiC#818 ) Summary of the changes: - Added the AUTO GEN CLI for the CFG DB tables required for this feature - Added the coredump_gen_handler.py & techsupport_cleanup.py scripts. - Added the UT's required for these scripts. - Enhanced coredump-compress & generate-dump scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vivek Reddy Karri vkarri@nvidia.com
The high-level design document for the "Event Driven TechSupport Invocation & CoreDump Mgmt" enhancement