MPLS EXP to TC mapping HLD #844
Conversation
doc/qos/mpls_exp_to_tc_map.md
Outdated
|
|
||
| ### 8.1. DB | ||
|
|
||
| The CONFIG DB will be updated to include a new "MPLS_EXP_TO_TC_MAP_TABLE" similar to the existing "DSCP_TO_TC_MAP_TABLE". This will have the following format: |
There was a problem hiding this comment.
We're changing the DSCP_TO_TC_MAP_TABLE table representation in the config-DB now, please refer to the below PR and ensure to follow the same model for MPLS TC to TC MAP table as well.
https://github.com/Azure/sonic-buildimage/pull/7375/files
There was a problem hiding this comment.
Is there any expected date when that PR is going to get in? We'd want the MPSL TC to TC MAP PR to get in for the November release. If the referenced PR isn't going to be merged soon or at least the existing comments to be addressed in order to come to a conclusion about how the map/list structure should look like, we could proceed with the existing design and come back and update it when that PR is also merged.
There was a problem hiding this comment.
Following up on the today's meeting for clarity - is the existing DSCP_TO_TC_MAP table structure an issue? If not, the new table is going to look exactly the same for MPLS. If it is an issue, could you please explain how you think the table structure should be updated?
There was a problem hiding this comment.
Our code now follows the new model
There was a problem hiding this comment.
A user can bind the MPLS_TC_TO_TC_MAP to the switch, port, and/or MPLS in-segment entry using the below SAI attributes:
SAI_SWITCH_ATTR_QOS_MPLS_EXP_TO_TC_MAP or SAI_PORT_ATTR_QOS_MPLS_EXP_TO_TC_MAP or SAI_INSEG_ENTRY_ATTR_MPLS_EXP_TO_TC_MAP.
The proposal defines an MPLS_TC_TO_TC_MAP. However it does not specify how an user can specify the binding of the map.
I've updated the proposal to include per-port binding configuration details. At this point we're not going to offer support for per-switch and per-inseg configuration as the scope is to offer the same amount of support as DSCP to TC map does in the beginning. |
|
@zhangyanzhao can this doc be merged? (All the code PRs for it are now in) |
This HLD presents the design for adding the MPLS EXP to TC QoS mapping, along the existing DSCP to TC mapping.
Code PRs:
swss-common: sonic-net/sonic-swss-common#537
swss: sonic-net/sonic-swss#1954
utilites: sonic-net/sonic-utilities#1875