Sachnaik/secureboot #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backporting #12692 PR on 202205 branch. The diffs of #12692 does not cleanly gets apply. on 202205 branch. Hence the patch #12692 slightly modified so that it can get applied on 202205 branch without functional break. Signed-off-by: Sachin Naik <sachnaik@cisco.com>
The older ONIE version does not support mokutil command. This backport changes will address the issue.
efivar -l "Secureboot" can return since there are multiple entries of variable name with Secureboot and SecureBootEnforce etc. The fix to look for exact Secureboot variable which basically provides UEFI secureboot is enabled or not. Signed-off-by: Sachin Naik <sachnaik@cisco.com>
|
@qiluo-msft would you please help review/approve? Thanks. |
abdosi
approved these changes
May 17, 2023
|
Approved based on this PR approval: sonic-net/sonic-buildimage#14246 |
|
cc @rlhui for viz. |
jon-nokia
pushed a commit
to jon-nokia/sonic-buildimage-msft
that referenced
this pull request
Aug 9, 2023
sonic-host-services submodule update with following changes 6eac2d3 Merge pull request sonic-net#19 from judyjoseph/macsec_feature_enable 31c6108 Sync has_per_asic_scope attribute to config_db in all namespaces for multi-asic 185547f Add UT to improve coverage, for namespace config update 7c3aca0 macsec_supported info is part of DEVICE_RUNTIME_METADATA itself.
jon-nokia
pushed a commit
to jon-nokia/sonic-buildimage-msft
that referenced
this pull request
Aug 9, 2023
Added below commits: 9b30690 jcaiMR Fri Dec 16 fix handleSwssNotification crash in dhcp6relay (sonic-net#28) 047afb7 jcaiMR Wed Dec 14 14:08:58 2022 +0800 Fix multiple vlan issue (sonic-net#27) ff6bec3 Vivek Thu Dec 8 09:44:15 2022 -0800 Made the Error log informative (sonic-net#22) 2fbe729 jcaiMR Wed Nov 30 14:41:53 2022 +0800 disable cfg dynamic change (sonic-net#25) 13d0805 Liu Shilong Wed Nov 30 10:54:11 2022 +0800 Use github code scanning instead of LGTM (sonic-net#26) 1e846f6 kellyyeh Wed Nov 23 14:36:02 2022 -0800 Fix packet range check for relay-reply packets (sonic-net#21) 4d19e13 kellyyeh Thu Nov 17 10:04:53 2022 -0800 Add unittest infrastructure (sonic-net#5) 7f4fdab jcaiMR Fri Nov 11 14:47:51 2022 +0800 fix packet range check issue (sonic-net#20) 257ecdf kellyyeh Thu Nov 3 11:34:11 2022 -0700 Add client packet UDP header length check (sonic-net#19)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To support UEFI secure boot on the 202205 branch
How I did it
The feature is supported at the master branch see
sonic-net/sonic-buildimage#12692
Backported sonic-net/sonic-buildimage#12692 from master to msft/202205 branch
PR for branch Azure/202205: sonic-net/sonic-buildimage#14246
How to verify it
Booted on UEFI secure boot enabled and disabled hardware.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Refer HLD: sonic-net/SONiC#1028
A picture of a cute animal (not mandatory but encouraged)