Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minigraph] populate bgp_asn in DEVICE_METADATA only if it is valid. … #415

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

gechiang
Copy link
Collaborator

…(#19413)

What I did:-
Populate bgp_asn in DEVICE_METADATA only if is present/valid.

Why I did:
Without this it causes Yang Validation failure for Systems that are Pure L2/Chassis Supervisor (no BGP) as Yang expects bgp_asn as valid as_number


Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

…(#19413)

What I did:-
Populate bgp_asn in DEVICE_METADATA only if is present/valid.

Why I did:
Without this it causes Yang Validation failure for Systems that are Pure
L2/Chassis Supervisor (no BGP) as Yang expects bgp_asn as valid
as_number

---------

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@gechiang gechiang requested a review from arlakshm July 14, 2024 01:09
@gechiang gechiang merged commit 37c4db5 into sonic-net:202205 Jul 15, 2024
3 checks passed
@gechiang
Copy link
Collaborator Author

Completed the cherry-pick to MSF repo for this Public PR: sonic-net/sonic-buildimage#19413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants