Skip to content

Commit

Permalink
[config] Remove "reset failed" print lines from config reload (#1654)
Browse files Browse the repository at this point in the history
#### What I did
I removed the following line from the `config reload` flow....

```
click.echo("Resetting failed status on {}".format(service))
```

This is called in the `_reset_failed_services()` function which is used to reset the systemd restart timers on services so that it doesn't prevent them from starting from the config reload. 

The above line results in the following lines being printed to the terminal when `config reload` is run

```
Resetting failed status on <service>.service
```

This gives the impression that the listed services failed at some point in their lifetime which is untrue and misleading to print to the terminal (in addition many rich-text terminals mark keywords such as "failed" red which further increases the implied severity of these log lines). I do not believe this operation needs any verbosity as it is a very simple operation that makes no user-visible changes thus the user should not need to be notified of it.
  • Loading branch information
alexrallen authored Jun 18, 2021
1 parent 285960d commit 3f0ecd5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion config/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,6 @@ def _get_sonic_services():

def _reset_failed_services():
for service in _get_sonic_services():
click.echo("Resetting failed status on {}".format(service))
clicommon.run_command("systemctl reset-failed {}".format(service))


Expand Down

0 comments on commit 3f0ecd5

Please sign in to comment.