[generate-dump] Remove Arista specific logic (#1482)

Cleanup review to remove Arista specific logic from generate_dump.
We now implement the vendor specific hw-management-generate-dump.sh hook which achieves the same purpose.

Signed-off-by: Samuel Angebault <staphylo@arista.com>

scripts/generate_dump

@@ -854,21 +854,6 @@ collect_broadcom() {
     copy_from_masic_docker "syncd" "/var/log/bcm_diag_post" "/var/log/bcm_diag_post"
 }
 
-###############################################################################
-# Collect Arista specific information
-# Globals:
-#  None
-# Arguments:
-#  None
-# Returns:
-#  None
-###############################################################################
-collect_arista() {
-    save_cmd "cat /proc/scd" "scd"
-    save_cmd "arista syseeprom" "arista.syseeprom"
-    save_cmd "arista dump" "arista.dump"
-}
-
 ###############################################################################
 # Save log file
 # Globals:
@@ -1148,10 +1133,6 @@ main() {
         collect_broadcom
     fi
 
-    if $GREP -qi "aboot_platform=.*arista" /host/machine.conf; then
-        collect_arista
-    fi
-
     # 2nd counter snapshot late. Need 2 snapshots to make sense of counters trend.
     save_counter_snapshot $asic 2