[syncd] Fix crash during stats polling (#586)

sonic-net · Apr 1, 2020 · 91792db · 91792db
1 parent d13521e
commit 91792db
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/syncd/Syncd.cpp b/syncd/Syncd.cpp
@@ -537,7 +537,7 @@ sai_status_t Syncd::processGetStatsEvent(
         counter_ids.push_back(val);
     }
 
-    std::vector<uint64_t> result;
+    std::vector<uint64_t> result(counter_ids.size());
 
     auto status = m_vendorSai->getStats(
             metaKey.objecttype,

diff --git a/syncd/VendorSai.cpp b/syncd/VendorSai.cpp
@@ -388,6 +388,12 @@ sai_status_t VendorSai::getStats(
             _In_ const sai_stat_id_t *counter_ids,
             _Out_ uint64_t *counters);
 
+    if (!counter_ids || !counters)
+    {
+        SWSS_LOG_ERROR("NULL pointer function argument");
+        return SAI_STATUS_INVALID_PARAMETER;
+    }
+
     switch ((int)object_type)
     {
         case SAI_OBJECT_TYPE_PORT: