TSA/B/C scripts run only in BGP instances for front end ASICs.

In addition skip enforcing it on route maps used between internal BGP sessions.
sonic-net · Jan 26, 2021 · 9505af0 · 9505af0
1 parent b2fea23
commit 9505af0
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 2 deletions.
diff --git a/dockers/docker-fpm-frr/TSA b/dockers/docker-fpm-frr/TSA
@@ -1,11 +1,18 @@
 #!/bin/bash
 
+# Check whether the routemap is for internal BGP sessions.
+function is_internal_route_map()
+{
+    [[ "$1" =~ .*"_INTERNAL_".* ]]
+}
+
 function check_not_installed()
 {
   c=0
   config=$(vtysh -c "show run")
   for route_map_name in $(echo "$config" | sed -ne 's/  neighbor \S* route-map \(\S*\) out/\1/p');
   do
+    is_internal_route_map $route_map_name && continue
     echo "$config" | egrep -q "^route-map $route_map_name permit 20$"
     c=$((c+$?))
     echo "$config" | egrep -q "^route-map $route_map_name deny 30$"
@@ -21,6 +28,7 @@ then
   TSA_FILE=$(mktemp)
   for route_map_name in $(echo "$config" | sed -ne 's/  neighbor \S* route-map \(\S*\) out/\1/p');
   do
+    is_internal_route_map $route_map_name && continue
     case "$route_map_name" in
       *V4*)
         ip_version=V4

diff --git a/dockers/docker-fpm-frr/TSB b/dockers/docker-fpm-frr/TSB
@@ -1,12 +1,19 @@
 #!/bin/bash
 
+# Check whether the routemap is for internal BGP sessions.
+function is_internal_route_map()
+{
+    [[ "$1" =~ .*"_INTERNAL_".* ]]
+}
+
 function check_installed()
 {
   c=0
   e=0
   config=$(vtysh -c "show run")
   for route_map_name in $(echo "$config" | sed -ne 's/  neighbor \S* route-map \(\S*\) out/\1/p');
   do
+    is_internal_route_map $route_map_name && continue
     echo "$config" | egrep -q "^route-map $route_map_name permit 20$"
     c=$((c+$?))
     e=$((e+1))
@@ -24,6 +31,7 @@ then
   TSB_FILE=$(mktemp)
   for route_map_name in $(echo "$config" | sed -ne 's/  neighbor \S* route-map \(\S*\) out/\1/p');
   do
+    is_internal_route_map $route_map_name && continue
     case "$route_map_name" in
       *V4*)
       ;;

diff --git a/dockers/docker-fpm-frr/TSC b/dockers/docker-fpm-frr/TSC
@@ -1,11 +1,18 @@
 #!/bin/bash
 
+# Check whether the routemap is for internal BGP sessions.
+function is_internal_route_map()
+{
+    [[ "$1" =~ .*"_INTERNAL_".* ]]
+}
+
 function check_not_installed()
 {
   c=0
   config=$(vtysh -c "show run")
   for route_map_name in $(echo "$config" | sed -ne 's/  neighbor \S* route-map \(\S*\) out/\1/p' | egrep 'V4|V6');
   do
+    is_internal_route_map $route_map_name && continue
     echo "$config" | egrep -q "^route-map $route_map_name permit 20$"
     c=$((c+$?))
     echo "$config" | egrep -q "^route-map $route_map_name deny 30$"
@@ -21,6 +28,7 @@ function check_installed()
   config=$(vtysh -c "show run")
   for route_map_name in $(echo "$config" | sed -ne 's/  neighbor \S* route-map \(\S*\) out/\1/p' | egrep 'V4|V6');
   do
+    is_internal_route_map $route_map_name && continue
     echo "$config" | egrep -q "^route-map $route_map_name permit 20$"
     c=$((c+$?))
     e=$((e+1))

diff --git a/dockers/docker-fpm-frr/base_image_files/TS b/dockers/docker-fpm-frr/base_image_files/TS
@@ -11,10 +11,17 @@ ASIC_CONF=/usr/share/sonic/device/$PLATFORM/asic.conf
 
 if [[ ($NUM_ASIC -gt 1) ]]; then
     asic=0
+    NAMESPACE_PREFIX='asic'
+
     while [ $asic -lt $NUM_ASIC ]
     do
-        echo -e "BGP"$asic" : \c"
-        docker exec -i bgp$asic /usr/bin/$1
+        # Run TSA/TSB/TSC scripts in BGP instance for frontend ASICs.
+        sub_role=`sonic-cfggen -d -v "DEVICE_METADATA['localhost']['sub_role']" -n $NAMESPACE_PREFIX$asic`
+        if [ $sub_role == 'FrontEnd' ]
+        then
+            echo -e "BGP"$asic" : \c"
+            docker exec -i bgp$asic /usr/bin/$1
+        fi
         asic=$[$asic+1]
     done
 else