Skip to content

Commit

Permalink
Fix LGTM warning
Browse files Browse the repository at this point in the history
  • Loading branch information
Junchao-Mellanox committed Aug 12, 2021
1 parent d70896e commit b163ae0
Show file tree
Hide file tree
Showing 9 changed files with 3 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@
try:
from sonic_platform_base.chassis_base import ChassisBase
from sonic_py_common.logger import Logger
import glob
import os
import sys
from functools import reduce

from . import utils
Expand Down Expand Up @@ -794,7 +792,7 @@ def get_module(self, index):
module
"""
self.initialize_single_module(index)
return super(Chassis, self).get_module(index)
return super(ModularChassis, self).get_module(index)

@utils.default_return(-1)
def get_module_index(self, module_name):
Expand Down
2 changes: 0 additions & 2 deletions platform/mellanox/mlnx-platform-api/sonic_platform/eeprom.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
#############################################################################
import os
import subprocess
import time
import subprocess

from sonic_py_common.logger import Logger
try:
Expand Down
2 changes: 1 addition & 1 deletion platform/mellanox/mlnx-platform-api/sonic_platform/fan.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
try:
from sonic_platform_base.fan_base import FanBase
from sonic_py_common.logger import Logger
from .led import FanLed, ComponentFaultyIndicator
from .led import ComponentFaultyIndicator
from . import utils
except ImportError as e:
raise ImportError (str(e) + "- required module not found")
Expand Down
2 changes: 0 additions & 2 deletions platform/mellanox/mlnx-platform-api/sonic_platform/module.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import os
import redis
import sys
import threading
from sonic_platform_base.module_base import ModuleBase
from sonic_py_common.logger import Logger
Expand Down
2 changes: 1 addition & 1 deletion platform/mellanox/mlnx-platform-api/tests/test_eeprom.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def test_chassis_eeprom(self, mock_eeprom_info):
def test_eeprom_init(self):
# Test symlink not exist, there is an exception
with pytest.raises(RuntimeError):
eeprom = Eeprom()
Eeprom()

@patch('os.path.exists', MagicMock(return_value=True))
@patch('os.path.islink', MagicMock(return_value=True))
Expand Down
1 change: 0 additions & 1 deletion platform/mellanox/mlnx-platform-api/tests/test_fan_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

from sonic_platform import utils
from sonic_platform.fan import Fan, PsuFan, COOLING_STATE_PATH
from sonic_platform.led import FanLed
from sonic_platform.fan_drawer import RealDrawer, VirtualDrawer
from sonic_platform.psu import Psu

Expand Down
1 change: 0 additions & 1 deletion platform/mellanox/mlnx-platform-api/tests/test_psu.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

from sonic_platform import utils
from sonic_platform.psu import FixedPsu, Psu
from sonic_platform.device_data import DeviceDataManager


class TestPsu:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import os
import select
import sys

from mock import MagicMock, patch
Expand Down
2 changes: 0 additions & 2 deletions platform/mellanox/mlnx-platform-api/tests/test_thermal.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import glob
import os
import pytest
import shutil
import sys
if sys.version_info.major == 3:
from unittest import mock
Expand Down

0 comments on commit b163ae0

Please sign in to comment.