Skip to content

Commit

Permalink
Handling Invalid CRM configuration gracefully (#2109)
Browse files Browse the repository at this point in the history
*When CRM table contains some invalid configurations, the existing logic parses all field values above it and doesn't parse the field values below it. On hitting the unknown field, crm orch returns the execution leaving the crm database inconsistent. To handle this gracefully CRM orch will just log the unknown field and continue processing the fields below the unknown field.
Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
  • Loading branch information
dgsudharsan authored Jan 12, 2022
1 parent d240cb2 commit b4b0003
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion orchagent/crmorch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,6 @@ void CrmOrch::handleSetCommand(const string& key, const vector<FieldValueTuple>&
else
{
SWSS_LOG_ERROR("Failed to parse CRM %s configuration. Unknown attribute %s.\n", key.c_str(), field.c_str());
return;
}
}
catch (const exception& e)
Expand Down

0 comments on commit b4b0003

Please sign in to comment.