[asan][aclorch] fix a memory leak in the SaiAttrWrapper::swap() (#2382)

* fix a leak caused by overriding this->m_attr (which contained a dynamically allocated list) in the SaiAttrWrapper::swap()
sonic-net · Aug 9, 2022 · d36c17d · d36c17d
1 parent 9f2e27b
commit d36c17d
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/orchagent/saiattr.cpp b/orchagent/saiattr.cpp
@@ -66,12 +66,10 @@ sai_attr_id_t SaiAttrWrapper::getAttrId() const
 
 void SaiAttrWrapper::swap(SaiAttrWrapper&& other)
 {
-    m_objectType = other.m_objectType;
-    m_meta = other.m_meta;
-    m_attr = other.m_attr;
-    m_serializedAttr = other.m_serializedAttr;
-    other.m_attr = sai_attribute_t{};
-    other.m_serializedAttr.clear();
+    std::swap(m_objectType, other.m_objectType);
+    std::swap(m_meta, other.m_meta);
+    std::swap(m_attr, other.m_attr);
+    std::swap(m_serializedAttr, other.m_serializedAttr);
 }
 
 void SaiAttrWrapper::init(