Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MultiAsic] sudo reboot command doesn't gracefully stop Asic syncd# on multiasic platform. #11377

Closed
mlok-nokia opened this issue Jul 7, 2022 · 0 comments · Fixed by sonic-net/sonic-utilities#2258

Comments

@mlok-nokia
Copy link
Contributor

Description

Function stop_sonic_service() in /usr/local/bin/reboot script doesn't handle stopping the Asic syncd# on multiasic platform. When issue command "sudo reboot", the below error message is shown:

admin@sonic:~$ sudo reboot
Error: No such container: syncd
/var/log: 3.8 GiB (4070150144 bytes) trimmed on /dev/loop1
/host: 24.9 GiB (26695229440 bytes) trimmed on /dev/sda3

Steps to reproduce the issue:

  1. Issue "sudo reboot" command on a multiasic platform. The following error message will shown
admin@sonic:~$ sudo reboot
Error: No such container: syncd

Describe the results you received:

When issue the "sudo reboot" command on the multiasic platform, the below error message is shown:

admin@sonic:~$ sudo reboot
Error: No such container: syncd

Describe the results you expected:

Such error message should not be shown

Output of show version:

It happens on the latest code.

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

abdosi pushed a commit to sonic-net/sonic-utilities that referenced this issue Jul 20, 2022
…n multiasic platform (#2258)

What I did
Function stop_sonic_service() in /usr/local/bin/reboot script doesn't handle stopping the Asic syncd# on multiasic platform. Instead, it only stops the syncd on non-multiasic platform. When issue command "sudo reboot", the below message will be shown.

admin@sonic:~$ sudo reboot
Error: No such container: syncd
Fixes sonic-net/sonic-buildimage#11377

How I did it
Add code the stop_sonic_services() to check and get NUM_ASIC. If it is multiasic, looping all asics and call the syncd_request_shutdown for each asic.

How to verify it
Issue the "sudo reboot" on the multiasic platform, the error message "Error: No such container: syncd" should not be shown.
yxieca pushed a commit to sonic-net/sonic-utilities that referenced this issue Jul 28, 2022
…n multiasic platform (#2258)

What I did
Function stop_sonic_service() in /usr/local/bin/reboot script doesn't handle stopping the Asic syncd# on multiasic platform. Instead, it only stops the syncd on non-multiasic platform. When issue command "sudo reboot", the below message will be shown.

admin@sonic:~$ sudo reboot
Error: No such container: syncd
Fixes sonic-net/sonic-buildimage#11377

How I did it
Add code the stop_sonic_services() to check and get NUM_ASIC. If it is multiasic, looping all asics and call the syncd_request_shutdown for each asic.

How to verify it
Issue the "sudo reboot" on the multiasic platform, the error message "Error: No such container: syncd" should not be shown.
malletvapid23 added a commit to malletvapid23/Sonic-Utility that referenced this issue Aug 3, 2023
…n multiasic platform (#2258)

What I did
Function stop_sonic_service() in /usr/local/bin/reboot script doesn't handle stopping the Asic syncd# on multiasic platform. Instead, it only stops the syncd on non-multiasic platform. When issue command "sudo reboot", the below message will be shown.

admin@sonic:~$ sudo reboot
Error: No such container: syncd
Fixes sonic-net/sonic-buildimage#11377

How I did it
Add code the stop_sonic_services() to check and get NUM_ASIC. If it is multiasic, looping all asics and call the syncd_request_shutdown for each asic.

How to verify it
Issue the "sudo reboot" on the multiasic platform, the error message "Error: No such container: syncd" should not be shown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant