-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VxLAN] Removing the VxLAN tunnel through CLI doesn't delete the tunnel from hardware #12063
Comments
Besides the bug fix, we should also add one test case for vxlan tunnel deletion |
@dgsudharsan |
@srj102 I see. In case of VNET deleting the VNET before VxLAN tunnel will clear the tunnel from the hardware. However the problem here I see is the CLI command to remove the VxLAN tunnel succeeds without throwing any dependency errors whether a tunnel map or VNET is associated with it. This needs to be fixed. |
@dgsudharsan the foll is the snippet for vxlan deletion.
w.r.t VNET, Today vxlanmgr has checks for vlan vni mappings to take care of usecases without CLI, So I think the check can be put here. doVxlanTunnelDeleteTask() ..
An additional check for m_vnetCache.size() can be added in vxlanmgr as part of doVxlanTunnelDeleteTask() and return false |
@srj102 I believe handling in CLI should be good enough as CLI is the only flow for delete. I have raised a fix sonic-net/sonic-utilities#2404 |
Closing this issue, #2404 already merged |
Description
After configuring a static VxLAN and VNET, trying to remove vxlan using CLI will result in successfully removing it in the application but not in the hardware. The reason is the delete task doesn't call any SAI API. (https://github.com/sonic-net/sonic-swss/blob/fd0c585d34de63dc9cca57bb7d508cadfe1125d4/orchagent/vxlanorch.cpp#L1536)
Previously the delete task had the flow of removing the tunnels sonic-net/sonic-swss#931. However this flow was modified in the commit sonic-net/sonic-swss@095f481 due to which delete vxlan will not make any SAI calls
Steps to reproduce the issue:
Describe the results you received:
Delete vxlan returns successfully without any errors but leaving the hardware tunnel intact
Describe the results you expected:
Delete should return success or show throw error if there are any references
Output of
show version
:Output of
show techsupport
:Additional information you deem important (e.g. issue happens only occasionally):
The text was updated successfully, but these errors were encountered: