Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of VXLAN tunnel removal #931

Merged
merged 16 commits into from
Jun 14, 2019

Conversation

pavel-shirshov
Copy link
Contributor

What I did
Add support of vxlan removal.

Why I did it
To remove vxlan termination of WR restore

How I verified it
with test from sonic-mgmt.

Details if related

Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

SWSS_LOG_ERROR("DEL operation is not implemented");
const auto& tunnel_name = request.getKeyString(0);

if(!isTunnelExists(tunnel_name))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd address it in separate PR

orchagent/vxlanorch.cpp Show resolved Hide resolved
@pavel-shirshov pavel-shirshov merged commit 4a67378 into sonic-net:master Jun 14, 2019
@pavel-shirshov pavel-shirshov deleted the pavelsh/vxlan_delete branch June 14, 2019 02:45
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…ity (sonic-net#931)

* add and modify command line utilities to support gearbox phy
* added build time mock unit tests

HLD is located at https://github.com/Azure/SONiC/blob/b817a12fd89520d3fd26bbc5897487928e7f6de7/doc/gearbox/gearbox_mgr_design.md

  Signed-off-by: syd.logan@broadcom.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants