Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need Yang for CHASSIS_MODULE table #12640

Closed
isabelmsft opened this issue Nov 8, 2022 · 1 comment · Fixed by #14007
Closed

Need Yang for CHASSIS_MODULE table #12640

isabelmsft opened this issue Nov 8, 2022 · 1 comment · Fixed by #14007
Assignees
@tjchadaga
Labels
YANG YANG model related changes

Comments

@isabelmsft
Copy link
Contributor

Description

We don't have Yang models for CHASSIS_MODULE table.

Steps to reproduce the issue:

  1. Attempt to use GCU to apply-patch writing to CHASSIS_MODULE table

Describe the results you received:

GCU patch application failed with error:
ValueError: Given patch is not valid because it has changes to tables without YANG models

Describe the results you expected:

GCU patch application success with successful write to ConfigDB

Output of show version:

admin@vlab-01:~$ show version

SONiC Software Version: SONiC.master.118843-40cbd3fe8
Distribution: Debian 11.3
Kernel: 5.10.0-12-2-amd64
Build commit: 40cbd3fe8
Build date: Wed Jul  6 14:46:15 UTC 2022
Built by: AzDevOps@sonic-build-workers-001QGK
@isabelmsft isabelmsft added the YANG YANG model related changes label Nov 8, 2022
@isabelmsft isabelmsft mentioned this issue Nov 8, 2022
Merged
@zhangyanzhao
Copy link
Collaborator

@rlhui can you please link the code PR if you already have? Thanks.

@rlhui rlhui assigned tjchadaga and unassigned rlhui Feb 10, 2023
@tjchadaga tjchadaga mentioned this issue Feb 27, 2023
Merged
8 tasks
xumia pushed a commit that referenced this issue Mar 7, 2023
@tjchadaga
Add yang model definition for CHASSIS_MODULE table (#14007)
ba30775 
Why I did it
Add yang model definition for CHASSIS_MODULE define and implemented for sonic chassis. HLD for this configuration is included in https://github.com/sonic-net/SONiC/blob/master/doc/pmon/pmon-chassis-design.md#configuration

Fixes #12640

How I did it
Added yang model definition, unit tests, sample config and documentation for the table

How to verify it
Validated config tree generation using "pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-voq-inband-interface.yang"

Built the below python-wheels to validate unit tests and other changes
target/python-wheels/bullseye/sonic_yang_mgmt-1.0-py3-none-any.whl
target/python-wheels/bullseye/sonic_yang_models-1.0-py3-none-any.whl
target/python-wheels/bullseye/sonic_config_engine-1.0-py3-none-any.whl
xumia pushed a commit to xumia/sonic-buildimage-1 that referenced this issue Mar 10, 2023
@tjchadaga @xumia
Add yang model definition for CHASSIS_MODULE table (sonic-net#14007)
7b33cf3 
Why I did it
Add yang model definition for CHASSIS_MODULE define and implemented for sonic chassis. HLD for this configuration is included in https://github.com/sonic-net/SONiC/blob/master/doc/pmon/pmon-chassis-design.md#configuration

Fixes sonic-net#12640

How I did it
Added yang model definition, unit tests, sample config and documentation for the table

How to verify it
Validated config tree generation using "pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-voq-inband-interface.yang"

Built the below python-wheels to validate unit tests and other changes
target/python-wheels/bullseye/sonic_yang_mgmt-1.0-py3-none-any.whl
target/python-wheels/bullseye/sonic_yang_models-1.0-py3-none-any.whl
target/python-wheels/bullseye/sonic_config_engine-1.0-py3-none-any.whl
yxieca pushed a commit that referenced this issue Mar 16, 2023
@tjchadaga
Add yang model definition for CHASSIS_MODULE table (#14007) (#14262)
df22ead 
Why I did it
Add yang model definition for CHASSIS_MODULE define and implemented for sonic chassis. HLD for this configuration is included in https://github.com/sonic-net/SONiC/blob/master/doc/pmon/pmon-chassis-design.md#configuration

Fixes #12640

How I did it
Added yang model definition, unit tests, sample config and documentation for the table

How to verify it
Validated config tree generation using "pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-voq-inband-interface.yang"

Built the below python-wheels to validate unit tests and other changes
target/python-wheels/bullseye/sonic_yang_mgmt-1.0-py3-none-any.whl
target/python-wheels/bullseye/sonic_yang_models-1.0-py3-none-any.whl
target/python-wheels/bullseye/sonic_config_engine-1.0-py3-none-any.whl
tjchadaga added a commit to tjchadaga/sonic-buildimage that referenced this issue Mar 20, 2023
@tjchadaga
Add yang model definition for CHASSIS_MODULE table (sonic-net#14007)
a61c54d 
Why I did it
Add yang model definition for CHASSIS_MODULE define and implemented for sonic chassis. HLD for this configuration is included in https://github.com/sonic-net/SONiC/blob/master/doc/pmon/pmon-chassis-design.md#configuration

Fixes sonic-net#12640

How I did it
Added yang model definition, unit tests, sample config and documentation for the table

How to verify it
Validated config tree generation using "pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-voq-inband-interface.yang"

Built the below python-wheels to validate unit tests and other changes
target/python-wheels/bullseye/sonic_yang_mgmt-1.0-py3-none-any.whl
target/python-wheels/bullseye/sonic_yang_models-1.0-py3-none-any.whl
target/python-wheels/bullseye/sonic_config_engine-1.0-py3-none-any.whl
@tjchadaga tjchadaga mentioned this issue Mar 20, 2023
Merged
8 tasks
yxieca pushed a commit that referenced this issue Jun 22, 2023
@tjchadaga
Add yang model definition for CHASSIS_MODULE table (#14007) (#14358)
f7dc0d1 
Why I did it
Add yang model definition for CHASSIS_MODULE define and implemented for sonic chassis. HLD for this configuration is included in https://github.com/sonic-net/SONiC/blob/master/doc/pmon/pmon-chassis-design.md#configuration

Fixes #12640

How I did it
Added yang model definition, unit tests, sample config and documentation for the table

How to verify it
Validated config tree generation using "pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-voq-inband-interface.yang"

Built the below python-wheels to validate unit tests and other changes
target/python-wheels/bullseye/sonic_yang_mgmt-1.0-py3-none-any.whl
target/python-wheels/bullseye/sonic_yang_models-1.0-py3-none-any.whl
target/python-wheels/bullseye/sonic_config_engine-1.0-py3-none-any.whl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjchadaga tjchadaga

Labels
YANG YANG model related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add yang model definition for CHASSIS_MODULE table
4 participants
@zhangyanzhao @rlhui @isabelmsft @tjchadaga